From: Colin Walters <walters@verbum.org>
Date: Thu, 12 Nov 2009 18:09:20 +0000 (-0500)
Subject: [dash] Convert pane close to St.Button, avoiding release event propagation
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~1013^2^2~10668
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=fec2ea5e9c0e0cc78d6238a951fe520a3347a1c1;p=gnome-shell.git

[dash] Convert pane close to St.Button, avoiding release event propagation

The workspaces was handling the release event after closing the pane,
catch it before closing by using St.Button.
---

diff --git a/js/ui/dash.js b/js/ui/dash.js
index fd5d947a9..3398fce9e 100644
--- a/js/ui/dash.js
+++ b/js/ui/dash.js
@@ -94,11 +94,9 @@ Pane.prototype = {
 
         let chromeTop = new St.BoxLayout();
 
-        let closeIcon = new St.Bin({ style_class: "dash-pane-close" });
-        closeIcon.reactive = true;
-        closeIcon.connect('button-press-event', Lang.bind(this, function (b, e) {
+        let closeIcon = new St.Button({ style_class: "dash-pane-close" });
+        closeIcon.connect('clicked', Lang.bind(this, function (b, e) {
             this.close();
-            return true;
         }));
         let dummy = new St.Bin();
         chromeTop.add(dummy, { expand: true });